Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and publish latest UI improvements and bux fixes #335

Closed
pcowgill opened this issue Apr 23, 2019 · 10 comments · Fixed by #348
Closed

Bump version and publish latest UI improvements and bux fixes #335

pcowgill opened this issue Apr 23, 2019 · 10 comments · Fixed by #348

Comments

@pcowgill
Copy link
Member

Once #333 and #331 are merged

@pcowgill pcowgill added this to the 0.1.0 release milestone Apr 23, 2019
@pcowgill pcowgill changed the title Publish latest UI improvements and bux fixes Bump version and publish latest UI improvements and bux fixes Apr 23, 2019
@pcowgill
Copy link
Member Author

@marcelomorgado I think the last commit from this PR #324 is the best one test to test an upgrade from to make sure there are no problems with the changes in persistent storage

@pcowgill
Copy link
Member Author

pcowgill commented Apr 24, 2019

So this commit 5cc4c82

@marcelomorgado
Copy link
Contributor

marcelomorgado commented Apr 24, 2019

Are we'll use that commit or the develop branch after merging fixes and reset accounts?

@pcowgill
Copy link
Member Author

@marcelomorgado Oh, good question. I guess that branch may not have been up to date with develop before merging it. Did the fixes you have in mind hit develop before or after merging that PR? Either way, we'll want the last commit from right before we actually published

@pcowgill
Copy link
Member Author

pcowgill commented Apr 24, 2019

It does look like develop was merged into that branch though, so I think it should have most of the fixes you're referring to if they were in develop before that PR #324

@marcelomorgado
Copy link
Contributor

I think that I wasn't clear on my question.
I've meant if we will publish a new version from this commit 5cc4c82
Or using the updated code with last changes (account reset) from branch #343
I've made that question because I've thought that commit has the storeIsFirstUse(false) command and it could be a problem with our intent to reset all accounts. But I've just realized that commit hasn't this command.

@pcowgill
Copy link
Member Author

pcowgill commented Apr 24, 2019

Oh no, we definitely wouldn't want to publish from 5cc4c82. That's the commit that I was saying would represent what's already been published for testing the upgrade path. So we'd use that as the BEFORE in a BEFORE and AFTER data migration test on our devices before publishing.

We would want to publish the code with the latest changes for sure.

Yeah, it would have been bad if we published an intermediate commit. And yeah, I think that commit 5cc4c82 was from before we made those changes.

@marcelomorgado
Copy link
Contributor

Ohh I see.

@pcowgill
Copy link
Member Author

@marcelomorgado So does that commit work as the BEFORE commit then? If so, I'll begin testing and use the open PR as the AFTER commit

@marcelomorgado
Copy link
Contributor

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants