-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version and publish latest UI improvements and bux fixes #335
Comments
@marcelomorgado I think the last commit from this PR #324 is the best one test to test an upgrade from to make sure there are no problems with the changes in persistent storage |
So this commit 5cc4c82 |
Are we'll use that commit or the |
@marcelomorgado Oh, good question. I guess that branch may not have been up to date with develop before merging it. Did the fixes you have in mind hit develop before or after merging that PR? Either way, we'll want the last commit from right before we actually published |
It does look like develop was merged into that branch though, so I think it should have most of the fixes you're referring to if they were in |
I think that I wasn't clear on my question. |
Oh no, we definitely wouldn't want to publish from 5cc4c82. That's the commit that I was saying would represent what's already been published for testing the upgrade path. So we'd use that as the We would want to publish the code with the latest changes for sure. Yeah, it would have been bad if we published an intermediate commit. And yeah, I think that commit 5cc4c82 was from before we made those changes. |
Ohh I see. |
@marcelomorgado So does that commit work as the |
Okay |
Once #333 and #331 are merged
The text was updated successfully, but these errors were encountered: