Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TextInput more mobile friendly in edit mode #31

Closed
teberl opened this issue Feb 11, 2019 · 0 comments
Closed

Make TextInput more mobile friendly in edit mode #31

teberl opened this issue Feb 11, 2019 · 0 comments

Comments

@teberl
Copy link
Contributor

teberl commented Feb 11, 2019

Based on #9 and this comment from @sindresorhus i would purpose a small improvement to
.todo-list li.editing .edit.

The width attribute there is fixed in size by 506px. This fact makes it break on my phone in edit mode.

Since the rest of the design is already responsive and works on all sizes (i tested), i would suggest to make this width dynamic by using
width: calc(100% - 43px)
where the 43px reflect the margin-left we set for compensating the toggle element for completion.

Not sure about the browser support we have to guarantee, but this would work for most common browsers caniuse .

sindresorhus pushed a commit that referenced this issue Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant