Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] ad-hoc-processing #31

Closed
wants to merge 4 commits into from

Conversation

andreujuanc
Copy link

@andreujuanc andreujuanc commented Mar 23, 2022

Closes #26

@andreujuanc andreujuanc changed the title ad-hoc-processing [Draft] ad-hoc-processing Mar 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@andreujuanc
Copy link
Author

andreujuanc commented Mar 23, 2022

We are using IaC that has a JS serializer to bundle and deploy code as AWS Lambdas, and the result from it by using the KMS is that the bundle is too big. We checked the dependencies and even webpack is included.
Tatum KMS has too many dependencies and some of them are actually devDependencies that are included as runtime ones.
We'll opt to run an instance of KMS running in fargate instead.

This PR still applies when trying to run a single run KMS to process a single transaction without blocking the thread, but feel free to close it and ignore if it does not fit the library's vision.

@balmacefa
Copy link

This is what I whats looking for.
This can also be improved by separating, the getPedingTransactions and Signed Transactions
for (const transaction of transactions) {
In case you already know the transaction ID, because this is return...
soo there is no need to loop through the list, some time some tx may get stuck due to gas or other scenario

@samuelsramko samuelsramko deleted the branch tatumio:master November 9, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split daemon and processSignatures
3 participants