Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/a-A-key-commands #48

Merged
merged 4 commits into from
Nov 10, 2023
Merged

feat/a-A-key-commands #48

merged 4 commits into from
Nov 10, 2023

Conversation

valxntine
Copy link
Collaborator

Adds a and shift_a functions, and relevant tests

Copy link
Owner

@tauraamui tauraamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the tests, just a couple of points! 💯

src/view.v Outdated Show resolved Hide resolved
- Changed increment from ++ to += 1
- Removed superfluous defer
Copy link
Owner

@tauraamui tauraamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@valxntine valxntine merged commit ef04d6d into master Nov 10, 2023
1 check passed
@tauraamui tauraamui deleted the feat/a-A-key-commands branch April 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants