Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/command-result-output #66

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix/command-result-output #66

merged 1 commit into from
Nov 17, 2023

Conversation

valxntine
Copy link
Collaborator

Removes last command buffer command check, meaning repeated commands trigger feedback properly.

Adds case for blank line to just return, same as if escape is pressed in command mode.

Entering : in command mode still triggers command unrecognized feedback message.

No new tests added but plenty of manual testing done.

…trigger feedback properly

Adds case for blank line to just return, same as if escape is pressed in command mode
Copy link
Owner

@tauraamui tauraamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giphy won't load, but I'm so sorry I missed this, please poke me in future.

@tauraamui tauraamui merged commit f4ae60d into master Nov 17, 2023
1 check passed
tauraamui added a commit that referenced this pull request Nov 17, 2023
…ommands trigger feedback properly (#66)"

This reverts commit f4ae60d.
@tauraamui tauraamui deleted the fix/command-result-output branch November 17, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants