Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Window::set_icon() on MacOS #3260

Closed
GaiBrutman opened this issue Jan 21, 2022 · 2 comments
Closed

Add support for Window::set_icon() on MacOS #3260

GaiBrutman opened this issue Jan 21, 2022 · 2 comments

Comments

@GaiBrutman
Copy link

GaiBrutman commented Jan 21, 2022

Describe the problem

When trying to change the app's window icon with window.set_icon(), I get the following error:
image `` extension not supported; please file a Tauri feature request (on 'png', 'jpg' and 'ico')

It looks like when compiled on MacOs, the extension option always panics:

_ => panic!(
"image `{}` extension not supported; please file a Tauri feature request",
extension
),

Describe the solution you'd like

Support for MacOS icon extensions needs to be added.

@GaiBrutman GaiBrutman changed the title Add support for Window::set_icon() in MacOS Add support for Window::set_icon() on MacOS Jan 21, 2022
@GaiBrutman
Copy link
Author

After looking into it, it seems like tau (as for 0.5.2) has no support for MacOS icons:
https://docs.rs/tao/0.5.2/tao/window/struct.Window.html#method.set_window_icon

@amrbashir
Copy link
Member

amrbashir commented Jan 28, 2022

indeed, setting an icon for a window on macos is not possible. however we can set the icon for the dock when we add dock management api. check #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants