-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming injection keys to avoid collisions #6
Comments
Extracting the actions to an external module may be a good way to go to so the package could keep the current behaviour and add a more robust one without breaking changes: import { onLoad, toggle, minimize } from 'tawk/actions' Happy to help with a PR here if maintainers consider this approach. |
No reply in months |
This would be incredibly important IMO! |
@IsraelOrtuno Thank you for submitting this issue, we would like to apologize for having a delay @chrisspiegl Yes this would be fix right away |
yeah this is a big oversight using such generic names |
@jaoaustero any news on this? |
Hello! Thanks for the package, definitely useful for a quick installation in a Vue/Nuxt app. I found something that may be quite tricky to deal with and is the fact that the package uses Vue 3
provide
to expose its api so it can be used anywhere. This is quite nice BUT the key names for these functions to be injected are too generic and are very likely to collision with other. I would suggest adding a prefix to those liketawk*
(whatever other pattern may work too):Specially the ones mentioned in the example are way to generic and chances are that these names may already exist in an application. I am aware this may be a breaking change but will definitely help users to use the package and prevent unexpected behaviours so it could maybe be released in a v2 release.
The text was updated successfully, but these errors were encountered: