Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: able to extend adapter specific exporter? #575

Open
wey-gu opened this issue Jun 17, 2024 · 2 comments
Open

feat: able to extend adapter specific exporter? #575

wey-gu opened this issue Jun 17, 2024 · 2 comments
Labels
adapter v2 enhancement New feature or request

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Jun 17, 2024

Is it reasonable/feasible to make the adapter support certain types of exported formats?

I am thinking of adding support to allow exporting .html file of a NebulaGraph query result(i.e. this), or dot profile file, etc.

This seems to only apply to a specific adapter?

Harlequin is a Great project, thanks so much for creating it!

@tconbeer
Copy link
Owner

Thanks, this is an interesting idea. Actually the v1 implementation of the exporter required adapter-specific implementations, but most adapter authors weren't implementing export, so I refactored to just use arrow + duckdb, which ship with Harlequin core. I could probably walk things back a bit, and bring back adapter-specific export implementations... I admittedly wasn't thinking about non-tabular data formats, but to be honest there is some work to support the full range of formats and options that we already have access to (e.g., more parquet options).

@wey-gu
Copy link
Contributor Author

wey-gu commented Jun 18, 2024

Simplifying the adapter integration surface in this change is highly reasonable. Your abstraction and contribution documentation are elegant and tasteful, making the adapter implementation feel comfortable. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter v2 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants