Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'infinity' timestamps #690

Open
yrashk opened this issue Nov 18, 2024 · 1 comment
Open

Support for 'infinity' timestamps #690

yrashk opened this issue Nov 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yrashk
Copy link

yrashk commented Nov 18, 2024

Postgres supports infinity timestamps.

=# select 'infinity'::timestamptz;
 timestamptz 
-------------
 infinity
(1 row)

However, this adapter doesn't:

CleanShot 2024-11-18 at 09 18 43@2x

It is, however, a valid and useful range to support, particularly in the context of temporal tables.

@tconbeer
Copy link
Owner

Interesting. I actually think this is a problem with Harlequin core, or more specifically, the data table implementation. We use Apache Arrow to store the data returned by the query, and I don't think Arrow supports infinity timestamps (they have an Arrow.max constant, I believe). We probably just need to catch this error and replace the infinity value with Arrow.max.

@tconbeer tconbeer changed the title Support for 'infinity' Support for 'infinity' timestamps Nov 18, 2024
@tconbeer tconbeer added the bug Something isn't working label Nov 18, 2024
@tconbeer tconbeer transferred this issue from tconbeer/harlequin-postgres Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants