Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installable via LuaRocks #35

Merged
merged 6 commits into from
Dec 1, 2024
Merged

Conversation

FourierTransformer
Copy link
Collaborator

@FourierTransformer FourierTransformer commented Dec 1, 2024

With this PR in place teal-language-server can now be installed on systems with LuaRocks 3.10.0+ and Node installed!

Changes

  • Switched to ltreesitter-ts which bundles the tree-sitter library as well as ltreesitter.
    • I put in an issue in the ltreesitter repo about potentially including the library as part of the bindings
  • Updated rockspec for the eventual new version
  • Added running tests as part of GHA
  • Updated LuaRocks to 3.10.0 in GHA (used to be 3.8.0)

Current Issues

  • Need to see if we can drop Node as a requirement. If the tree-sitter CLI can generate a grammar from the JSON file without Node, it should be possible.
  • It will only install on LuaRocks 3.10.0 and above
    • This is due to the changes that happened to custom build systems in 3.10.0. When I was working on tree-sitter-cli, I was initially targeting 3.8.0, but ran into issues with newer versions of LuaRocks. I'm sure there's some way to get it all working.

helps #26

@FourierTransformer
Copy link
Collaborator Author

FourierTransformer commented Dec 1, 2024

Not sure why the build is failing, planning to have it fixed before merging. The script works locally and my hererocks [local] setup also works just fine. When installing tree-sitter-cli, it seems to not be able to find the builder for it, which is a bit odd.

Turns out it worked locally because I had the tree-sitter-cli builder installed at the system level and it was finding that. When I removed it, I started getting the same error message.

The error message was about not being able to find the builder, which got fixed by upgrading to LuaRocks 3.10.0+. I think there might by ways to support versions below 3.10.0. I'll investigate that a bit, and see what can be done. The workaround for now is updating LuaRocks to 3.10.0+.

I'll continue tracking some of this in #26

@FourierTransformer FourierTransformer marked this pull request as ready for review December 1, 2024 22:46
@FourierTransformer FourierTransformer merged commit f1f9117 into main Dec 1, 2024
8 checks passed
@FourierTransformer FourierTransformer deleted the luarocks-installable branch December 1, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant