Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update express-sms-webinar to Typescript #24

Merged
merged 3 commits into from
Oct 15, 2024
Merged

update express-sms-webinar to Typescript #24

merged 3 commits into from
Oct 15, 2024

Conversation

lucasassisrosa
Copy link
Contributor

@lucasassisrosa lucasassisrosa commented Oct 9, 2024 •
edited
Loading

BueTelnyx
BueTelnyx approved these changes Oct 14, 2024
View reviewed changes
Copy link

@BueTelnyx BueTelnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, actually texted an image through of a goat. That text did take an extremely long time to get a response back, maybe because of the size of the image?

@lucasassisrosa
Copy link
Contributor Author

Works great, actually texted an image through of a goat. That text did take an extremely long time to get a response back, maybe because of the size of the image?

yes, I think so. The image is 500 kb so considering it was sent through sms that might be the case

@lucasassisrosa lucasassisrosa merged commit 6c2286c into master Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BueTelnyx BueTelnyx BueTelnyx approved these changes

@chasenpse chasenpse Awaiting requested review from chasenpse

@DRS90 DRS90 Awaiting requested review from DRS90

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasassisrosa @BueTelnyx