[mod] 마이 피드 / 상세페이지에서 삭제시 화면 처리 #185
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ class MainActivity : BindingActivity<ActivityMainBinding>(R.layout.activity_main | |
| private val isUploadSuccess by lazy { intent.extras?.getBoolean(EXTRA_UPLOAD_KEY, false) } | ||
| private val isDeleteSuccess by lazy { intent.extras?.getBoolean(EXTRA_DELETE_KEY, false) } | ||
| private val isReportSuccess by lazy { intent.extras?.getBoolean(EXTRA_REPORT_KEY, false) } | ||
| private val prevScreenName by lazy { intent.extras?.getString(KEY_PREV_SCREEN, "") } | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
@@ -45,17 +46,14 @@ class MainActivity : BindingActivity<ActivityMainBinding>(R.layout.activity_main | |
| } | ||
|
|
||
| private fun initFragment() { | ||
| if (intent.getBooleanExtra(KEY_TO_MYPAGE, false)) { | ||
| navigateToMyPageWithBundle(KEY_FROM_NOTI, true) | ||
| } else { | ||
| if (prevScreenName == MY_FEED_SCREEN) { | ||
| navigateToMyPageWithBundle(KEY_TO_MYFEED, true) | ||
| } else { | ||
| navigateTo<WineyFeedFragment>() | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -131,9 +129,27 @@ class MainActivity : BindingActivity<ActivityMainBinding>(R.layout.activity_main | |
| } | ||
| } | ||
|
|
||
| private fun navigateToMyPageWithBundle(key: String, value: Boolean) { | ||
| supportFragmentManager.commit { | ||
| val bundle = Bundle() | ||
| bundle.putBoolean(key, value) | ||
| val myPageFragment = MyPageFragment() | ||
| myPageFragment.arguments = bundle | ||
| replace(R.id.fcv_main, myPageFragment) | ||
| binding.bnvMain.selectedItemId = R.id.menu_mypage | ||
| } | ||
|
There was a problem hiding this comment. fragment-ktx 를 이용하면 코드를 조금 더 단순화 할 수 있을 거 같아요!
fragmentManager().commit {
addToBackStack("...")
setCustomAnimations(
R.anim.enter_anim,
R.anim.exit_anim)
add(fragment, "...")
}/**
* Run [body] in a [FragmentTransaction] which is automatically committed if it completes without
* exception.
*
* The transaction will be completed by calling [FragmentTransaction.commit] unless [allowStateLoss]
* is set to `true` in which case [FragmentTransaction.commitAllowingStateLoss] will be used.
*/
public inline fun FragmentManager.commit(
allowStateLoss: Boolean = false,
body: FragmentTransaction.() -> Unit
) {
val transaction = beginTransaction()
transaction.body()
if (allowStateLoss) {
transaction.commitAllowingStateLoss()
} else {
transaction.commit()
}
}commit 확장 함수 안에서 body 라는 람다식을 사용하기 때문에 코드의 가독성이 좀 더 올라가는 거 같습니다! :) |
||
| } | ||
|
|
||
| companion object { | ||
| private const val EXTRA_UPLOAD_KEY = "upload" | ||
| private const val EXTRA_DELETE_KEY = "delete" | ||
| private const val EXTRA_REPORT_KEY = "report" | ||
|
|
||
| private const val KEY_PREV_SCREEN = "PREV_SCREEN_NAME" | ||
| private const val KEY_FROM_NOTI = "fromNoti" | ||
| private const val KEY_TO_MYFEED = "toMyFeed" | ||
| private const val KEY_TO_MYPAGE = "navigateMypage" | ||
|
|
||
| private const val MY_FEED_SCREEN = "MyFeedFragment" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
번들의 key 값도 상수화 시켜주면 더 좋을 거 같아요 😊