Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod] 마이페이지 / 닉네임 수정 뷰에서 원래 닉네임의 글자수 표시 #187

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[mod] 마이페이지 / 닉네임 수정 뷰에서 원래 닉네임의 글자수 표시 #187

merged 1 commit into from
Sep 5, 2023

Conversation

leeeha
Copy link
Member

@leeeha leeeha commented Sep 5, 2023

📝 Work Description

  • 아요, 기획 파트 의견에 따라 힌트 텍스트도 글자수 카운팅 해서 우측에 표시하기로 했습니다!

📣 To Reviewers

  • 오늘 자정까지 확인 부탁해요~~!!

@leeeha leeeha added mod 〰 코드 및 내부 파일 수정 하은 🐰 labels Sep 5, 2023
@leeeha leeeha added this to the 기능 구현 ✨ milestone Sep 5, 2023
@leeeha leeeha requested review from sxunea and Sangwook123 September 5, 2023 04:03
@leeeha leeeha self-assigned this Sep 5, 2023
sxunea
sxunea approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@sxunea sxunea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 ~!

app/src/main/java/org/go/sopt/winey/util/binding/BindingAdapter.kt
"app:prevScreenName",
"app:inputNicknameLength",
"app:originalNicknameLength",
requireAll = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 속성 알아갑니다 👍

@leeeha leeeha merged commit 5df067b into develop Sep 5, 2023
1 check passed
@leeeha leeeha deleted the feature/mod-nickname-hint-counter branch September 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxunea sxunea sxunea approved these changes

@Sangwook123 Sangwook123 Awaiting requested review from Sangwook123

Assignees

@leeeha leeeha

Labels
mod 〰 코드 및 내부 파일 수정 하은 🐰
Projects
Winey-AOS
Status: Done
Milestone
기능 구현 ✨
Development

Successfully merging this pull request may close these issues.

[mod] 마이페이지 / 닉네임 수정 뷰에서 힌트 텍스트 글자수 표시
2 participants
@leeeha @sxunea