fix(log-cleanup): Argument list too long #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airflow instances with a lot of DAG runs create lots of small log files. The `find` command is able to search for patterns, iterating over and deleting them. However, the old way would use the shell's globbing feature and pass the directories to check for as individual arguments. This may caused an "Argument list too long" error.
| @@ -175,20 +175,23 @@ | |||
| echo "" | |||
| echo "Running Cleanup Process..." | |||
|
|
|||
| FIND_STATEMENT="find ${BASE_LOG_FOLDER}/*/* -type f -mtime \ | |||
| # Delete log files | |||
| FIND_STATEMENT="find ${BASE_LOG_FOLDER} -type f -mtime \ | |||
There was a problem hiding this comment.
Suggested change
| FIND_STATEMENT="find ${BASE_LOG_FOLDER} -type f -mtime \ | |
| FIND_STATEMENT="find ${BASE_LOG_FOLDER}/* -name ""*"" -type f -mtime \ |
There was a problem hiding this comment.
this is enough to fix the issue. And find statement for empty folders should be fine
There was a problem hiding this comment.
You may commit this change if you want, but I see no difference there. The -name only adds a check which should always be true. Appending the /* should also have no effect, as the -type f check will ensure, we only delete files anyway.
We run this patch internally for quite some time now without any issues.
Deleting around 8k files a day.
There was a problem hiding this comment.
FIND_STATEMENT="find ${BASE_LOG_FOLDER}/* -name ""*"" -type f -mtime \
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow instances with a lot of DAG runs create lots of small log files.
The
findcommand is able to search for patterns, iterating over anddeleting them. However, the old way would use the shell's globbing
feature and pass the directories to check for as individual arguments.
This can cause an "Argument list too long" error.