Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle the argument input like NaN.bs2ad('2075/04/00') #6

Open
ohmmee opened this issue Aug 21, 2018 · 1 comment
Open

handle the argument input like NaN.bs2ad('2075/04/00') #6

ohmmee opened this issue Aug 21, 2018 · 1 comment

Comments

@ohmmee
Copy link

ohmmee commented Aug 21, 2018

.bs2ad('2075/04/00') gives out the last month's converted date
if possible, handle the way the input is received

like if('2018/02/31') is passed as an argument for ad2bs then, it also gives out result
which is absurd because feb cant have 31 days

@techgaun
Copy link
Owner

techgaun commented Jan 2, 2020

Good point. Always good to add additional validations around the input. While I think it would be great to have this, I don't have bandwidth myself to work on this. If I find time, I may try to crack this problem and get it figured. Meanwhile, library/package users should handle that in the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants