Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

totalDaysInMonth separate function for getting the total days in the given month #7

Open
ohmmee opened this issue Aug 21, 2018 · 1 comment

Comments

@ohmmee
Copy link

ohmmee commented Aug 21, 2018

new Date(year, month, 0).getDate( ) can be used for english

similar type of inbuilt function for getting the last date of the month of BS date if there's any in the inner array of year and months data of every years.

The library gives the feature while conversion from AD to BS but not while passing BS
en: {
totalDaysInMonth: totalDays
}
is available but not for BS date like ('2075/05/06')
gotta do the hack like converting to AD, then getting totalDaysInMonth and if I'm working with only nepali months, parsing only year and month of BS and giving default value to date and the convert to AD and get totalDaysInMonth

Thankyou

@techgaun
Copy link
Owner

techgaun commented Jan 2, 2020

good point. thanks @ohmmee for opening this issue. this should not be a big lift. Would you be interested to tackle this and open a PR? Otherwise, I can find some time over next month or so to get this feature request in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants