Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow anon to see all profiles #273

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: allow anon to see all profiles #273

merged 1 commit into from
Oct 14, 2024

Conversation

raphael-arce
Copy link
Collaborator

@raphael-arce raphael-arce commented Oct 11, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de-postgres-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 11:54am

@raphael-arce raphael-arce mentioned this pull request Oct 11, 2024
Merged
aeschi
aeschi previously approved these changes Oct 14, 2024
View reviewed changes
Copy link

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Jaszkowic
Jaszkowic requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Jaszkowic Jaszkowic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: For security purposes, it would be better to have a database function that checks for a given username if it already exists. That way, we do not expose this table (including all user ids and all profile names) to the public.

@raphael-arce
Copy link
Collaborator Author

@Jaszkowic could you have another look? thanks 🙏

@Jaszkowic Jaszkowic self-requested a review October 14, 2024 12:49
Jaszkowic
Jaszkowic approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Jaszkowic Jaszkowic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphael-arce raphael-arce merged commit c2a1fd5 into staging Oct 14, 2024
4 checks passed
@raphael-arce raphael-arce deleted the feat/allow-anon-select-profile branch October 14, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaszkowic Jaszkowic Jaszkowic approved these changes

@aeschi aeschi aeschi left review comments

@ff6347 ff6347 Awaiting requested review from ff6347

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphael-arce @Jaszkowic @aeschi