* re-added docker-compose-no-https.yml to be able to start lasius in … #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…production without self-signed certificate * cover non-https case in setup script * auto-generate admin password for mongodb instance
|
Related to tegonal/Lasius#36 |
setup.sh
Outdated
| @@ -110,6 +110,21 @@ if [ "$mode" == "production" ]; then | |||
| break | |||
| fi | |||
| done | |||
|
|
|||
| while true; do | |||
| read -rp "Start lasius in https mode (with self-signed certificate)? (y/n) " yn | |||
There was a problem hiding this comment.
"self-signed" could be misleading here. Isn't it a Let's Encrypt certificate? When I read self-signed, I think of a certificate that has not been signed by a trusted CA but one that I have signed myself and therefore is not trusted by browsers by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…production without self-signed certificate