introduce Representation as marker to solve ambiguities #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so far we ran into ambiguity issues if an arg was a String, it was not clear without providing a named argument whether the representation was meant or another arguments => This is a breaking change rename append argX to args so that we can always use the same named parameter and don't have to change the number if the given arg changes => this is a breaking change as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far we ran into ambiguity issues if an arg was a String, it was not clear without providing a named argument whether the representation was meant or another arguments
=> This is a breaking change
rename append argX to args so that we can always use the same named parameter and don't have to change the number if the given arg changes => this is a breaking change as well
I confirm that I have read the Contributor Agreement v1.1, agree to be bound on them and confirm that my contribution is compliant.