Import changes from #2152 to NGSI-LD dockerfile #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Apr 25, 2022
docker/cygnus-ngsi-ld/Dockerfile
Outdated
Comment on lines
20
to
21
| # as we did with cygnus-ngsi Dockerfile. Basically, the changes done in PR https://github.com/telefonicaid/fiware-cygnus/pull/2152 | ||
| # should be also applied here |
There was a problem hiding this comment.
This FIXME block should be removed
|
Following line: should be added to CHANGES_NEXT_RELEASE |
Done in 605de24 |
I have approved the PR but it would be great to have LGTM from Jason before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2152 changes base image from centos 8 to Debian in NGSI Dockerfile. This PR mimics changes applied for NGSI-LD Dockerfile
@jason-fox Please, can you build and check if everything keeps working properly?