-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attribute loss when updating entity #1667
base: master
Are you sure you want to change the base?
fix: attribute loss when updating entity #1667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a commented here #1660 (comment) a test case about his issue is needed.
@GuillaumeOd please have a look to documentation in the case it has to change to describe the new behaviour with this PR. |
This PR is reverting this commit: 166f771 |
6c34980
to
d9e6fdf
Compare
@GuillaumeOd not sure if I'm getting the point... You want to send measures like this:
and get corresponding attribute at CB this way:
is my interpretation correct? |
@fgalan Yes, exactly! Regarding the type, I'm not entirely sure if it should be Could you try running the test locally without my fix to confirm it fails as expected? |
In that case, why don't use at provisioning time
instead of
? |
related to #1660