Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Flyout Canvas appNameLink does not do anything #2378

Open
AC40 opened this issue Jan 3, 2025 · 0 comments
Open

Mobile Flyout Canvas appNameLink does not do anything #2378

AC40 opened this issue Jan 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@AC40
Copy link

AC40 commented Jan 3, 2025

Scale Version
3.0.0-beta.154

Framework and version
plain HTML, CSS and JS

Current Behavior
When creating a mobile nav menu corresponding to to a desktop layout, the Scale API provides the scale-telekom-mobile-flyout-canvas. It can be seen in use in the examples provided by the Scale Team.
This component provides the appNameLink component which, changes nothing. The app name remains uninteractable.

Expected Behavior
Given the documentation, the naming conventions, and other components, such as <scale-telekom-header> I would expect this to turn the app name to a link.

Code Reproduction

<scale-telekom-nav-item class="burger-item">
    <button>
         <scale-badge>
             <scale-icon-action-menu></scale-icon-action-menu>
         </scale-badge>
     </button>
          <scale-telekom-nav-flyout class="mobile-nav-flyout">
           <!-- the mobile navigation structure goes here -->
               <scale-telekom-mobile-flyout-canvas app-name="Standard Version" app-name-link="/foo">
                   <scale-telekom-mobile-menu slot="mobile-main-nav">
                       <scale-telekom-mobile-menu-item active>
                           <a href="#">Topic One</a>
                       </scale-telekom-mobile-menu-item>
                   </scale-telekom-mobile-menu>
                </scale-telekom-mobile-flyout-canvas>
         </scale-telekom-nav-flyout>
</scale-telekom-nav-item>

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome, Firefox
  • Version 131.0.6778.205 (Chrome), 133 (Firefox)

Additional context
After inspecting the code for the the <scale-telekom-mobile-flyout-canvas> I found something I thought was peculiar:
The variable appNameLink (which is what is changed by setting the app-name-link attribute) does seem to ever be used inside the component .
It is very possible I am missing something, but the other references to this symbol are only from other, as far as I can tell unrelated, files.

Was the app-name-link functionality not actually implemented (yet), is the documentation wrong, or am I missing something?
Thanks you for looking into this!

@AC40 AC40 added the bug Something isn't working label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant