Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Redmine 2.3 #28

Open
xadh00m opened this issue Jun 4, 2013 · 2 comments
Open

Fix for Redmine 2.3 #28

xadh00m opened this issue Jun 4, 2013 · 2 comments

Comments

@xadh00m
Copy link

xadh00m commented Jun 4, 2013

Hi,

After upgrading redmine to 2.3 the plugin throws a routing exception because the routes syntax has changed. I was able to fix that issue by changing the syntax in config/routes.rb file to:

Rails.application.routes.draw do
match '/stealth/toggle', :to => 'stealth#toggle'
end
else
Rails.application.routes.draw do |map|
map.connect '/stealth/toggle',
:controller => 'stealth', :action => 'toggle',
:conditions => { :method => :post }
end

This is probably not backward compatible but works fine on redmine 2.3.

@R-i-c-k-y
Copy link

sorry, it does not work

Regards

On Tue, Jun 4, 2013 at 2:29 PM, xadh00m [email protected] wrote:

Hi,

After upgrading redmine to 2.3 the plugin throws a routing exception
because the routes syntax has changed. I was able to fix that issue by
changing the syntax in config/routes.rb file to:

Rails.application.routes.draw do
match '/stealth/toggle', :to => 'stealth#toggle'
end
else
Rails.application.routes.draw do |map|
map.connect '/stealth/toggle',
:controller => 'stealth', :action => 'toggle',
:conditions => { :method => :post }
end

This is probably not backward compatible but works fine on redmine 2.3.


Reply to this email directly or view it on GitHubhttps://github.com//issues/28
.

mlutfy added a commit to mlutfy/redmine_stealth that referenced this issue Jan 2, 2015
@mlutfy
Copy link

mlutfy commented Jan 2, 2015

Thanks @xadh00m for the patch! That fix worked for me, but also needed to replace link_to_remote by link_to, since link_to_remote is removed from Rails 3, which is what I suspect @R-i-c-k-y ran into.

I added those patches in a PR I sent to the project maintainer:
#32

I have a working branch tested on Redmine 2.5 (Debian Wheezy) available here:
https://github.com/mlutfy/redmine_stealth/tree/redmine-2.5

Please test & feedback, I am by no means an expert in Ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants