Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit issues #91

Open
itsdalmo opened this issue Dec 16, 2022 · 0 comments
Open

Rate limit issues #91

itsdalmo opened this issue Dec 16, 2022 · 0 comments

Comments

@itsdalmo
Copy link
Contributor

I made a comment here #82 (comment) which I'm not sure you saw @SadriG91 and @mansn-at-telia:

Been a while since I worked on Github Apps, but I'd imagine its the Github provider and not the Github store that is being rate limited (unless you are rotating credentials for thousands of accounts, and/or very very frequently). If its the Github provider, then I don't imagine MultiApp will help since you have no control over how and when the access tokens are used - i.e. a single access token could consume the entire rate limit in a short time?

From the outset the plan was to scale Sidecred by having multiple deployments, each with their own Github App - but I take it you are still centrally managing it? Are you perhaps also using the same Github App for both the store and the provider?

I might have misunderstood something here, but it seems like using multiple apps is a somewhat brittle solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant