Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add sample for client TLS config #189

Open
tsurdilo opened this issue Mar 28, 2022 · 4 comments
Open

[Feature Request] Add sample for client TLS config #189

tsurdilo opened this issue Mar 28, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@tsurdilo
Copy link
Contributor

I was not able to find a sample on how to set up client options with TSL enabled.
Does not have to be running, could be just a config example that users can cut/paste, similar to what we have in java samples: https://github.com/temporalio/samples-java/blob/main/src/main/java/io/temporal/samples/ssl/SslEnabledWorker.java

Related user forum thread: https://community.temporal.io/t/help-how-to-create-a-client-with-tls/4287

@tsurdilo tsurdilo added the enhancement New feature or request label Mar 28, 2022
@cretz
Copy link
Member

cretz commented Mar 28, 2022

TLS is a Go concept not a Temporal one. The client.ConnectionOptions.TLS configuration value is a Go TLS config not a Temporal one.

Having said that, we can have a sample showing how to use Go TLS.

@YashishDua
Copy link

YashishDua commented Apr 3, 2022

@cretz I would love to contribute to this project by taking up this issue. Let me know how the process looks like :)

@cretz
Copy link
Member

cretz commented Apr 4, 2022

In this case, I was thinking a new dir called mtls w/ a sample like the helloworld one but the starter/worker code uses mtls via keys stored here in the repo (see the serverjwtauth sample) and the README would explain how to setup mTLS.

If you want to take this on, a simple PR is perfect.

@gmendoza-wenance
Copy link

I am very interested in such an example. I'm keeping an eye on this issue. Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants