feat: prune abandoned state #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-state # Conflicts: # x/farming/keeper/invariants_test.go # x/farming/keeper/keeper_test.go # x/farming/keeper/reward_test.go # x/farming/keeper/staking_test.go
dongsam
reviewed
Nov 11, 2021
dongsam
suggested changes
Nov 12, 2021
There was a problem hiding this comment.
I think there are some errors in the current method (if there are multiple stakings for the same staking denom and add staking, withdrawing) I think there will be not enough time to review and correct it in this v1.0.0-rc1 release, so it seems necessary to correct it more meticulously in the next sprint.
…e-state # Conflicts: # x/farming/keeper/staking.go
12 tasks
|
LGTM, Thank you for fixing logic and adding detailed test code. As a result of internal discussions, we think that the PR is not essential for this release, so we will include it in the next release. |
dongsam
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By introducing reference counting similar to the x/distribution module, we can safely prune abandoned state
like no longer used
HistoricalRewards,OutstandingRewards,CurrentEpoch, ....closes: #142
References
See: F1 Fee Distribution Paper's 3. State Requirements for details about state pruning using reference counting.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes