Release/v0.10.0 #144
Release/v0.10.0 #144
Conversation
Ledger integration
* Return errors on priv.Sign(), priv.PubKey() * Add CreateLedger, CreateOffline * Add switch on .Sign() for Ledger wallets * Add offline signing switch on .Sign() * Use MustUnmarshalBinaryBare() * Add confirmation to delete offline/Ledger keys * Lowercase error message * Add human-readable .GetType() function to Info interface * Rename CryptoAlgo => SignAlgo * assert.Nil(t, err) => assert.NoError(t, err)
* move from tmlibs 213 * expose KVPair, simpleproofsfrommap returns keys
make PubKeyEd25519.Address() returns the first 20 bytes of the hash of the raw 32-byte pubkey, no amino required
include an example, do not err check on info ... bur for empty info instead
…name # Conflicts: # Gopkg.lock # keys/keybase_test.go # signature_test.go
SignatureKey -> Signature
version bump
* Remove error from priv.PubKey() * Update changelog
* circleci 2.0
* Switch from xchachapoly to hkdfchachapoly
… BIP 44) (#118) - fundraiser compatibility for HD keys (BIP 39 & BIP 32 / BIP 44)
- it will be moved to cosmos-sdk
- also delete ledger code and deps (thx cwgoes) Signed-off-by: Liamsi <[email protected]>
Yes, develop was merged into tendermint. We thought, we might "retire" go-crypto by making it a private repo as as soon as the merge is through. Hence we took the develop branch and did not create a release before (cc @cwgoes)
We deleted the entire keys package here (7ebc7c0 and a589e0e). It is not needed in tendermint. Merging into cosmos-sdk happend exactly like into to tendermint (from develop) but with reverting these two commits (and deleting everything else). |
When looking into the version of go-crypto that got merged into Tendermint to try and accurately document the breaking changes, I noticed a few things:
37 commits ahead, 6 commits behind masterIt looks like develop is what got merged into tendermint, but it has more changes that aren't captured on master or in a release, so we can't actually say "version X of go-crypto was merged into tendermint". This is somewhat unfortunate.
As for the commits on master not on develop, I'm not exactly sure what happened, but some seem to be in Tendermint and some don't - in particular the recent
This is a combination of X commits.commits are missing.I have done the following:
I'm not sure if there is something here that is missing in the tendermint/crypto or in the
keysthat got moved to SDK.I'm mostly just concerned with accurately documenting the breaking changes in go-crypto so that when we release Tendermint with crypto moved in, we can say exactly what happened.