Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function.ipynb #2264

Closed
wants to merge 1 commit into from
Closed

Conversation

NinoRisteski
Copy link
Contributor

two typo fixes in function.ipynb

two typo fixes in function.ipynb
@NinoRisteski NinoRisteski requested a review from a team as a code owner August 30, 2023 13:54
@google-cla
Copy link

google-cla bot commented Aug 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

@MarkDaoust
Copy link
Member

Hey @NinoRisteski, thanks for the PR.

The change looks good, and I can see that you've signed the CLA, but the CLA bot won't let me merge because the email on the commit (95188570+NinoRisteski​@users.noreply.github.com) doesn't match the email you signed with. Can you resubmit without the "keep my email address private" option?

@github-actions github-actions bot added the lgtm Community-added approval label Aug 30, 2023
@NinoRisteski
Copy link
Contributor Author

Hi @MarkDaoust, I just resubmitted with the same mail as my github profile. Hope its good now?

@MarkDaoust
Copy link
Member

resubmitted

Where? I don't see any change or new PR.

@NinoRisteski
Copy link
Contributor Author

I resubmitted the CLA with the same email as my GitHub profile. Should I make another commit, or new PR?

@MarkDaoust
Copy link
Member

Cool, I can see that you've signed the CLA with two email addresses, the problem right now is that the commit itself is tagged with a different autogenerated address, not the one you signed the CLA with. So CLA bot doesn't recognize it as you.

In the checks section check under the details link.

So I think you need to make a new PR, or fix it and force-push this branch.

@MarkDaoust
Copy link
Member

Fixed in #2265

@MarkDaoust MarkDaoust closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants