-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update function.ipynb #2264
Update function.ipynb #2264
Conversation
two typo fixes in function.ipynb
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PreviewPreview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin patch-1
|
Hey @NinoRisteski, thanks for the PR. The change looks good, and I can see that you've signed the CLA, but the CLA bot won't let me merge because the email on the commit (95188570+NinoRisteski@users.noreply.github.com) doesn't match the email you signed with. Can you resubmit without the "keep my email address private" option? |
Hi @MarkDaoust, I just resubmitted with the same mail as my github profile. Hope its good now? |
Where? I don't see any change or new PR. |
I resubmitted the CLA with the same email as my GitHub profile. Should I make another commit, or new PR? |
Cool, I can see that you've signed the CLA with two email addresses, the problem right now is that the commit itself is tagged with a different autogenerated address, not the one you signed the CLA with. So CLA bot doesn't recognize it as you. In the So I think you need to make a new PR, or fix it and force-push this branch. |
Fixed in #2265 |
two typo fixes in function.ipynb