Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched YAMNet to stick with Keras 2. #11261

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

plakal
Copy link
Collaborator

@plakal plakal commented Sep 23, 2024

Description

Switched YAMNet to stick with Keras 2. TF 2.16 switched the default to Keras 3
which is backwards incompatible.

closes #11212

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

Installed latest versions of all dependences (including new tf_keras) and
ran yamnet_test.py

Test Configuration:

Checklist

TF 2.16 switched the default to Keras 3 which is backwards incompatible.
@plakal plakal requested a review from dpwe as a code owner September 23, 2024 18:12
@plakal plakal requested review from dpwe and removed request for dpwe September 23, 2024 18:13
Copy link
Collaborator

@dpwe dpwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for figuring this out!

@plakal plakal merged commit c651073 into tensorflow:master Sep 24, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot initialise YAMNet using TF 2.16.1
2 participants