From d0919221b688d6ddfb8b8c865ba1678cce6a3138 Mon Sep 17 00:00:00 2001 From: Carlos Ezequiel Date: Mon, 15 May 2023 13:24:34 -0400 Subject: [PATCH] Update code based on reviewer comments. - Fix issues in pred2bq readme - Reverted version change in setup.py - Add abls-py test prerequisite in setup.py --- setup.py | 2 +- tfx_addons/predictions_to_bigquery/README.md | 8 +++++--- tfx_addons/version.py | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/setup.py b/setup.py index 5db798e3..56e98a80 100644 --- a/setup.py +++ b/setup.py @@ -57,7 +57,7 @@ def get_long_description(): return fp.read() -TESTS_REQUIRE = ["pytest", "pylint", "pre-commit", "isort", "yapf"] +TESTS_REQUIRE = ["pytest", "pylint", "pre-commit", "isort", "yapf", "absl-py"] PKG_REQUIRES = get_pkg_metadata() EXTRAS_REQUIRE = PKG_REQUIRES.copy() diff --git a/tfx_addons/predictions_to_bigquery/README.md b/tfx_addons/predictions_to_bigquery/README.md index 94d6b0b9..aecef72c 100644 --- a/tfx_addons/predictions_to_bigquery/README.md +++ b/tfx_addons/predictions_to_bigquery/README.md @@ -58,7 +58,8 @@ import tfx_addons as tfxa ... predictions_to_bigquery = tfxa.predictions_to_bigquery.PredictionsToBigQuery( - schema=schema_gen.outputs['schema'] + inference_results=bulk_inferrer.outputs['inference_result'], + schema=schema_gen.outputs['schema'], transform_graph=transform.outputs['transform_graph'], bq_table_name='my_bigquery_table', gcs_temp_dir='gs://bucket/temp-dir', @@ -66,7 +67,8 @@ predictions_to_bigquery = tfxa.predictions_to_bigquery.PredictionsToBigQuery( ) ``` -TFX pipeline examples can be found in `integration_test.py`. +Refer to `integration_test.py` for tests that demonstrates how to use the +component. For a description of the inputs and execution parameters of the component, refer to the `component.py` file. @@ -77,7 +79,7 @@ See `version.py` in the top repo directory for component dependencies. ## Testing -Each Python module has a correspondin unit test file ending in `_test.py`. +Each Python module has a corresponding unit test file ending in `_test.py`. An integration test is also available and requires use of a Google Cloud project. Additional instructions for running the unit test can be found in `integration_test.py`. diff --git a/tfx_addons/version.py b/tfx_addons/version.py index 8c036f61..df85c376 100644 --- a/tfx_addons/version.py +++ b/tfx_addons/version.py @@ -16,7 +16,7 @@ # We follow Semantic Versioning (https://semver.org/) _MAJOR_VERSION = "0" -_MINOR_VERSION = "7" +_MINOR_VERSION = "6" _PATCH_VERSION = "0" # When building releases, we can update this value on the release branch to