Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aten.index.Tensor #535

Open
jdh8 opened this issue Dec 2, 2024 · 1 comment · May be fixed by #559
Open

aten.index.Tensor #535

jdh8 opened this issue Dec 2, 2024 · 1 comment · May be fixed by #559
Assignees

Comments

@jdh8
Copy link
Collaborator

jdh8 commented Dec 2, 2024

No description provided.

@swimdi swimdi self-assigned this Dec 3, 2024
@swimdi swimdi linked a pull request Dec 5, 2024 that will close this issue
@swimdi swimdi linked a pull request Dec 5, 2024 that will close this issue
@swimdi
Copy link
Collaborator

swimdi commented Dec 9, 2024

In #559 it lowering aten.index.Tensor to serveral aten.reshape/getitem/aten.cat, but aten.reshape have no lowering yet

I try to add lowering of aten.reshape, but got this error

pytest tests/lowering/misc/test_index.py

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
    getitem_3 = ttnn_to_device_1[1]

peError: object of type 'ttnn._ttnn.tensor.Tensor' has no len()

It seems failed at getitem_3 = ttnn_to_device_1[1], I think there have two way to solved it

  1. find why getitem_3 = ttnn_to_device_1[1] failed and TT add the support
  2. not use getitem, use aten.select and later lowering it to ttnn.reshape & ttnnn.slice, but because the dim, start is node not int/float, so aten.select need to exapand its support

c.c. @ayerofieiev-tt @pschang-phy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants