Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Installer for XbimXplorer #41

Open
teocomi opened this issue Aug 7, 2017 · 8 comments
Open

Installer for XbimXplorer #41

teocomi opened this issue Aug 7, 2017 · 8 comments

Comments

@teocomi
Copy link
Owner

teocomi commented Aug 7, 2017

Hey @CBenghi , I'm about to roll out a new version of BCFier with some improvements. Should I include support for XbimXplorer in the installer? If so how? I'm not familiar with it...

@CBenghi
Copy link
Collaborator

CBenghi commented Aug 23, 2017

Hello,
sorry for the late reply I was on holiday.
No need to do anything in the installer; plugins have an online update system, I'll have to merge your code changes and push the library to our online repo.

Thanks for letting me know.
I'll keep you posted.

Claudio

@CBenghi
Copy link
Collaborator

CBenghi commented Aug 23, 2017

I've merged your latest changes to my repository.
I'll make the plugin available to Xplorer soon.

I wonder if it would instead help to distribute your core libs as a nuget package; updates to third parties might be simpler, but maybe it's overkill.

Thanks,
Claudio

@teocomi
Copy link
Owner Author

teocomi commented Aug 31, 2017

Hi Claudio, it's a good idea but yes, it might be overkill for now given that as far as I know only Xplorer is using BCFier.

@CBenghi
Copy link
Collaborator

CBenghi commented Sep 1, 2017

On the other hand, once the package is in nuget more people might use it, and it's very little effort to add a nuspec file to the project.
I can give it an initial look if you wish and send a PR if it works.
You'll have to create a nuget user, though, I think it would be better for IP if it was done in your name.

@teocomi
Copy link
Owner Author

teocomi commented Sep 1, 2017

Sounds good, we've got nothing to lose. Appreciate that.

@CBenghi
Copy link
Collaborator

CBenghi commented Sep 5, 2017

Hello,
I've started looking into the nuget packaging this morning and one thing seems odd in the architecture.
All other projects are marked 'InternalsVisibleTo' from BCFier.

I think this should be changed (something made available as public) to make the API usable to others.

XbimXplorer uses the following:

'AddView' does not contain a definition for 'Issue'
'AddView' does not contain a definition for 'TempFolder'
'AddView' does not contain a definition for 'TextBlockInfo'
'AddView' does not contain a definition for 'AddViewpoint'

but I can't compile the others, would it be OK to change the signatures of these 4 (or add appropriate methods)?

Let me know and I'll progress.
Claudio

@teocomi
Copy link
Owner Author

teocomi commented Sep 14, 2017

Hi Claudio,
yes I guess that decision was made when BCFier wasn't Open Source yet, feel free to change the signature.

@CBenghi
Copy link
Collaborator

CBenghi commented Sep 14, 2017

Got it, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants