-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for contributions - Usage patterns #311
Comments
Hi @bryantbiggs, many thanks once again for pushing the major v9 upgrade; conversion of lists to maps as well as inclusion of a li'l Route 53 have been excellent additions. To aid debugging a separate issue, I published this repo which makes heavy use of the latest ALB module. Most notably, it features locals {
services = {
alpha = { port = 80 }
bravo = { port = 80 }
}
}
...
target_groups = {
for key, value in local.services : key => {
name = key
backend_port = value.port
target_type = "ip"
create_attachment = false
}
} Beyond keeping code DRY, I've found it to be a really useful pattern for leveraging the benefits of nested object maps across IaC configuration, particularly in the context of provisioning ECS services in bulk. Is this the sort of snippet that you're looking for contribution, or perhaps something more substantial than this? Edit: Based on this pattern, I've opened #327 for consideration. |
I believe making use of typed variables (with detailed validations on each field which gives feedback to the developer while trying to use it) would be very beneficial, vs. definitions with type "any". Is there a reason why this isn't being done? Is it fear of backwards compatability? |
Yes - the use of fully structured variable definitions have been quite problematic. We have not revisited this with the new optional arguments, but the gain seems to be marginal at best when compared with the overhead and complexity of maintaining such definitions |
thanks all for the contributions! If there are additional patterns that are of interest, please feel free to let us know, but for now we'll close out this issue |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a problem? Please describe.
Describe the solution you'd like.
Describe alternatives you've considered.
Additional context
The text was updated successfully, but these errors were encountered: