Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default use_policy_name_prefix and use_role_name_prefix to true in log forwarder module #43

Open
Ryankey opened this issue Sep 26, 2024 · 0 comments

Comments

@Ryankey
Copy link

Ryankey commented Sep 26, 2024

Is your request related to a new offering from AWS?

Not related to AWS Provider

Is your request related to a problem? Please describe.

The log forwarder lambda module was working well when testing in a single account & region, but errored once we started applying it to other regions, with the error EntityAlreadyExists: Role with name datadog-log-forwarder already exists.. Note that this didn't fail during plan, since the globally unique IAM role name rule is checked at creation time.

Describe the solution you'd like.

The fix is simply using the use_*_prefix variables, which I think should be defaulted to true. It's rarely the case that most users would want the module to work in only one region per account, and there's no downside to using the prefix for the single region case. It also more closely matches Datadog's CloudFormation stack which applies globally unique suffixes.

Describe alternatives you've considered.

N/A - workaround is to set the prefix flags true manually.

Additional context

Resource results from running datadog's cloudformation stack
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant