Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support externally created source and target endpoint ARNs #72

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

kellenanker7
Copy link
Contributor

@kellenanker7 kellenanker7 commented Sep 9, 2024

Description

support overriding source_endpoint_arn and target_endpoint_arn to var.replication_tasks

Motivation and Context

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kellenanker7 kellenanker7 changed the title Support overriding source_endpoint_arn and target_endpoint_arn feat: Support overriding source_endpoint_arn and target_endpoint_arn Sep 9, 2024
@bryantbiggs bryantbiggs changed the title feat: Support overriding source_endpoint_arn and target_endpoint_arn feat: Support externally created source and target endpoint ARNs Sep 9, 2024
@bryantbiggs bryantbiggs merged commit 2575ab3 into terraform-aws-modules:master Sep 9, 2024
9 of 10 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 9, 2024
## [2.3.0](v2.2.1...v2.3.0) (2024-09-09)

### Features

* Support externally created source and target endpoint ARNs ([#72](#72)) ([2575ab3](2575ab3))
@antonbabenko
Copy link
Member

This PR is included in version 2.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support external endpoint ARNs
3 participants