feat: Add CloudWatch log group name to outputs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-kortum-trustedshops
changed the title
bryantbiggs
changed the title
bryantbiggs
approved these changes
Nov 19, 2024
bryantbiggs
merged commit 0fc0e19
into
terraform-aws-modules:master
10 of 11 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Nov 19, 2024
|
This PR is included in version 3.2.0 🎉 |
kevin-kortum-trustedshops
deleted the
feat/add-log-group-name-to-outputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new output to the module for cloudwatch log groups
Motivation and Context
I need to have to log group name to pass it to another module. Unfortunately, i only have the arn of the log group and the aws data source for the ressource won't allow a lookup by arn. Its easier to add the value to this module.
Breaking Changes
Nope. Just more data in your outputs. This change should align nicely with the currently provided output in the aws-rds module :)
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request