-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANCE compatibility with the newest version of transformers #14
Comments
Hi. Have you tried just installed transformers 4 once pyt_ance is installed? If you can do that, and post the error message, I can try to see how to fix. |
Thank you for your quick reply. I've tried that. Here is the dependency error:
And the error message while running ANCE: |
Ok I remember now. Have a look at this PR: https://github.com/cmacdonald/ANCE/pull/1/files, which I think may work for transformers 4 as well. |
Thanks a lot! It worked with some small modifications for the ance/model/models.py file (e.g., |
We dont use ANCE a lot, as it tends just to be a baseline for other experiments. We would need to extend the github testing to check multiple transformer versions (see how we did it https://github.com/terrierteam/pyterrier_colbert/pull/41/files). Happy to take a PR that fixes this though. |
Hi, this is the PR that I created. I tested it in my own project and ANCE is working just fine with transformers==4.9.0. right now. |
thanks. I'll want to make things work with old and new transformers versions. Leave it with me. |
Great, thank you for your help! |
Hi,
I'm trying to use ANCE dense retriever followed by a T5 re-ranker implemented using the transformers package. I'm getting the dependency conflicts, as pyterrier_ance requires transformers==2.3.0, but I need to use a newer version that contains T5 model. Currently, I'm using transformers==4.9.0.
@cmacdonald @seanmacavaney @tonellotto @Xiao0728
The text was updated successfully, but these errors were encountered: