Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find collision components optionally for environment test suite #941

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Sep 22, 2023

Changes per commit message

@Levi-Armstrong
Copy link
Contributor

I really do not like this for the unit tests, because it is to easy for this to get broken you will never know that the tests are not being ran as part of the pipeline. Why is this needed?

@marip8
Copy link
Contributor Author

marip8 commented Sep 22, 2023

Why is this needed?

I almost never build FCL locally, so when I also build unit tests locally this causes my whole build to fail

@Levi-Armstrong
Copy link
Contributor

I understand but I would rather this not be default behavior for unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants