Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure storing of credentials #12

Open
nvuillam opened this issue Dec 11, 2024 · 4 comments
Open

Secure storing of credentials #12

nvuillam opened this issue Dec 11, 2024 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@nvuillam
Copy link

nvuillam commented Dec 11, 2024

Credentials should not be stored in a repository

Would it be possible to provide them:

  • using ENV variables (they could be defined on CI/CD config), in SALESFORCE_USERNAME and SALESFORCE_PASSWORD vars for example
  • from a .env file that would be locally defined but not committed thanks to .gitignore

Thanks :)

@nvuillam nvuillam added enhancement New feature or request question Further information is requested labels Dec 11, 2024
@generalrobin
Copy link
Collaborator

Yes @nvuillam . This can be easily added with a small precommit hook and we will look into the same.

@nvuillam
Copy link
Author

What do you want to add in a pre-commit hook ? :)
We need to not commit such values 😋

@shriyanshagnihotri
Copy link
Contributor

@nvuillam so we have a custom script that can pull the data from AWS KMS, Google secrets and create a test_data secret file on the fly during the execution. @generalrobin is trying to mention the same that this script can be called by the hook in the CI/CD before actually doing the test case execution, in such cases we don't have to put secrets in the flat file.

The script and integration is still under development.

@nvuillam
Copy link
Author

@shriyanshagnihotri that's great :)
But we also need more simple ways to handle that locally ith not commited .env file, and with ENV variables for CI (remember: Salesforce people are less tech than others 😋 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants