Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Let database name be configurable in OracleContainer #7190

Closed
aalmiray opened this issue Jun 14, 2023 · 3 comments
Closed

[Enhancement]: Let database name be configurable in OracleContainer #7190

aalmiray opened this issue Jun 14, 2023 · 3 comments

Comments

@aalmiray
Copy link

Module

Oracle-XE

Proposal

When using the oracle-xe images the default database name is XEPDB1.
When using the oracle-free images the default database name should be FREEPDB1.

At the moment XEPDB1 is always assumed which means oracle-free images can't be used with default values. One must configure a random database name for the correct value to be picked up.

Add an option to define the default database name, opting for XEPDB1 or FREEPDB1 if none selected. A test on the image name could be applied to determine which default database name should be chosen, that is, if it matches/contains gvenzl/oci-oracle-free then FREEPDB1 is chosen, otherwise default to XEPDB1.

Follow up to spring-projects/spring-data-relational#1528

@eddumelendez
Copy link
Member

Thanks for raising the issue, @aalmiray. There is a current conversation going on with @gvenzl about the support for Oracle Free. I think this issue falls there

@gvenzl
Copy link
Contributor

gvenzl commented Jun 14, 2023

Yeah, let's use this issue here to document the progress of the discussion, @eddumelendez, as Spring wishes to monitor the outcome.

@aalmiray
Copy link
Author

aalmiray commented Nov 3, 2023

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants