Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile syntax highlight bug, improper function colorization in dependency list #16

Open
aeschli opened this issue Jun 21, 2017 · 1 comment
Open

Makefile syntax highlight bug, improper function colorization in dependency list #16

aeschli opened this issue Jun 21, 2017 · 1 comment

Comments

@aeschli
Copy link

aeschli commented Jun 21, 2017

From @Leedehai on June 21, 2017 0:4

  • VSCode Version: 1.13.1
  • OS Version: macOS 10.12.5

Steps to Reproduce:
In this Makefile snippet's dependency list, if the variable $(T_AUX_MESSAGES_DRIVER_SRC) is put before the function call $(addprefix $(T_PROJ_SRC_DIR), $(...) $(...)), then "addprefix" is not properly colorized.
image
If I change the order, "addprefix" colorization is fine.
image
This bug might be present with other functions as well, like "patsubst", but I didn't try..

Copied from original issue: microsoft/vscode#29148
@aeschli aeschli mentioned this issue Jun 21, 2017
Closed
@fadeevab
Copy link

fadeevab commented Aug 27, 2017 •
edited
Loading

This issue is fixed in pull request: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fadeevab @aeschli