Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to node.js after it merges with io.js #3

Closed
tfennelly opened this issue Sep 4, 2015 · 1 comment
Closed

Switch back to node.js after it merges with io.js #3

tfennelly opened this issue Sep 4, 2015 · 1 comment
Labels
task

Comments

@tfennelly
Copy link
Owner

We temporarily switched to using/requiring io.js because that allowed us to use a version of the jsdom package that didn't have a dependency on contextify (a package that causes a lot of pain for people building on Windows).

Go back and make relevant POM changes etc (e.g. manual/ugly io.js download and install for frontend-maven-plug) once node.js and io.js have merged back and things have settled down (don't go with the first version or two).

Related issue: #2
@tfennelly tfennelly added the task label Sep 4, 2015
@tfennelly tfennelly mentioned this issue Sep 4, 2015
Open
@tfennelly
Copy link
Owner Author

Fixed in jenkins-js-builder

tfennelly added a commit that referenced this issue Sep 9, 2016
@tfennelly
[JENKINS-35735] Fixes for IE compatibility (#3)
43b0f4e 
* rename import to importModule

* rename require to requireModule

* Missing semi-colon

* rename export to exportModule

* 0.0.7.beta1

* 0.0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfennelly