Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create type for Reading from Source to AST #171

Closed
tgockel opened this issue Apr 23, 2022 · 0 comments
Closed

Create type for Reading from Source to AST #171

tgockel opened this issue Apr 23, 2022 · 0 comments
Assignees
@tgockel
Labels
component-parsing enhancement
Milestone
Version 2.0.0

Comments

@tgockel
Copy link
Owner

tgockel commented Apr 23, 2022

As part of #150, there needs to be a type for reading from an ast_index called reader. This will allow extractors to not have to deal with ast_indexes directly.
@tgockel tgockel added this to the Version 2.0.0 milestone Apr 23, 2022
@tgockel tgockel self-assigned this Apr 23, 2022
tgockel added a commit that referenced this issue Apr 23, 2022
@tgockel
Creates reader type for converting from JSON source to AST node seq…
7567f7a 
…uence

A `jsonv::reader` instance reads from some form of JSON source (probably
a string, but the `jsonv::ast_index` type can theoretically read from
anything JSON-like) and converts it into `jsonv::ast_node`s. These
abstract reading from JSON source to normalize `extract` implementations,
which is needed for #150.

- Resolves #171
@tgockel tgockel mentioned this issue Apr 23, 2022
Merged
@tgockel tgockel closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgockel tgockel

Labels
component-parsing enhancement
Projects
None yet
Milestone
Version 2.0.0
Development

No branches or pull requests
1 participant
@tgockel