Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Hooks #21

Open
tgockel opened this issue Aug 11, 2017 · 3 comments
Open

Logging Hooks #21

tgockel opened this issue Aug 11, 2017 · 3 comments

Comments

@tgockel
Copy link
Owner

tgockel commented Aug 11, 2017

The C client's logging leaves a lot to be desired. Since log_callback_fn is simply void (*)(const char *message), we do not have a way to do basic things:

  • Quickly post-filter by level
  • Use a void* or other user data
  • Transform the output in any way that requires context

We probably just want to work around this...or fix the C API's logging.

@tgockel tgockel added this to the v0.1 milestone Aug 12, 2017
@tgockel tgockel modified the milestones: v0.2, v0.1 Sep 1, 2017
@tgockel
Copy link
Owner Author

tgockel commented Sep 1, 2017

Pushing this to v0.2 so we can think about configuration as a whole.

@tgockel
Copy link
Owner Author

tgockel commented Jan 27, 2018

I opened ZOOKEEPER-2969 in an attempt to get the C API changed to something a bit more usable, but no response. There's some argument to copying the C code and using my own internal copy. They're both Apache licensed, so that's A-OK.

@tgockel tgockel modified the milestones: v0.2.0, v0.3.0 Mar 2, 2018
@tgockel
Copy link
Owner Author

tgockel commented Mar 2, 2018

Pushing to 0.3 because ZK C API...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant