-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View item details #40
Conversation
Visit the preview URL for this PR (updated for commit bf0762d): https://tcl-76-smart-shopping-list--pr40-sm-view-item-details-urkzd2dq.web.app (expires Wed, 02 Oct 2024 18:37:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works great!
nit-pick/non-blocking: To set us up for adding CSS later, can we make the list items as <p>
instead of <h2>
? They just look a little big.
nit-pick/non-blocking: In the View Details section, can we add a space between the three stats? They currently look like this: "Last Purchase:Fri Sep 20 2024" and I'm wanting a space after the colon: "Last Purchase: Fri Sep 20 2024".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested by adding a new item and making purchases, and all data was correctly reflected in the div.
Hi, I added fontSize inline for now and added a span around the date to get the spacing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it everything is working on my end.
Description
ListItem
created a div to hold item detailsdateNextPurchased
andtotalPurchases
from theitem
objectIdeally, we can use this as a base for more stylistic choices coming up.
Related Issue
closes #37 (#21)
Acceptance Criteria
dateLastPurchased
,dateNextPurchase
, andtotalPurchases
pertaining to a single item.Type of Changes
enhancement
Updates
After
Testing Steps / QA Criteria
List
and there should be aView Purchase Details
buttondateLastPurchased
,dateNextPurchase
, andtotalPurchases
are the same as whats displayed