You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first one is that is raising an error but I opened a PR for that: #66
The second one is that when I add a missing city, if I try to find cities for a state other the one that I added, it does not load the city. It only loads the new city if I call .cities first for the state that I'm adding the missing record.
Example:
Add the following file: db/cities-lookup.yml
BR:
GO:
"Mutunópolis": "Mutunópolis"
If I load first cities for other state, it does not include this missing city:
bin/rails c
CS.cities(:sp, :br) # loading another state first
CS.cities(:go, :br).include?("Mutunópolis")
#> false
returned false but it should be true.
If I load this state first, it works correctly
bin/rails c
CS.cities(:go, :br).include?("Mutunópolis")
#> true
do u folks have any idea why this is happening? Thanks
The text was updated successfully, but these errors were encountered:
duduribeiro
added a commit
to duduribeiro/city-state
that referenced
this issue
Nov 24, 2023
Closesthecodecrate#67
There is a problem with city_lookup. It only loads the cities for the
first statue you called `cities` on. This is because `cities` memoizes
all the cities for the country, but `city_lookup` only loads the cities
for the state, and doesn't get called again for the other states.
Ex:
having the following `db/cities-lookup.yml`:
```yaml
BR:
GO:
"Mutunópolis": "Mutunópolis"
```
If I load first cities for other state, it does not include this missing
city:
```shell
bin/rails c
CS.cities(:sp, :br) # loading another state first
CS.cities(:go, :br).include?("Mutunópolis")
```
returned false but it should be true.
If I load this state first, it works correctly
```shell
bin/rails c
CS.cities(:go, :br).include?("Mutunópolis")
```
This commit changes `city_lookup` to load all the cities for the country.
I'm having an issue while adding a missing city.
The first one is that is raising an error but I opened a PR for that: #66
The second one is that when I add a missing city, if I try to find cities for a state other the one that I added, it does not load the city. It only loads the new city if I call
.cities
first for the state that I'm adding the missing record.Example:
db/cities-lookup.yml
If I load first cities for other state, it does not include this missing city:
returned false but it should be true.
If I load this state first, it works correctly
do u folks have any idea why this is happening? Thanks
The text was updated successfully, but these errors were encountered: