Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yggdrasil to 0.4.1 #11181

Draft
wants to merge 2 commits into
base: rpm/develop
Choose a base branch
from

Conversation

adamruzicka
Copy link

let's see what happens

@adamruzicka
Copy link
Author

Welp, el7 has meson-0.55.1, yggdrasil requires >= 0.58.0 so even if I would sort out those failures, we'd lose el7. Gues that's a no-go

LONGNAME=%{name} \
PKGNAME=%{name} \
VERSION=%{version}
%meson "-Dgobuildflags=%buildflags" %ldflags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really correct to pass the ldflags to meson? Looks like all versions don't like that. https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/ suggests that normally it should be able to figure it out by default.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yggdrasil 0.4.1 is in centos-stream 9 at least. If we don't make any modifications, I'd prefer to rely on that once RHEL 9.5 comes out. As for EL 7 & 8: I wouldn't mind keeping them on older versions.

In our package manifest and comps files we can tell the build system to only build for EL 7, 8 and OpenSUSE.

@adamruzicka adamruzicka force-pushed the rpm/develop-ygg-0.4.z branch from c89808c to d89862d Compare October 30, 2024 13:00
Just want to get the lints out of the way to see if this would work on
different distributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants