Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1889 instances not deinitializing when they're supposed to #1892

Closed
yingKatsu opened this issue Nov 3, 2024 · 14 comments · Fixed by #1893 or #1899
Closed

#1889 instances not deinitializing when they're supposed to #1892

yingKatsu opened this issue Nov 3, 2024 · 14 comments · Fixed by #1893 or #1899

Comments

@yingKatsu
Copy link
Contributor

#1889
most likely fullupdate related
Untitled

@thegrb93
Copy link
Owner

thegrb93 commented Nov 3, 2024

Is that in clientside or serverside or both?

@NullLikesNothing
Copy link

@thegrb93 It happens client-side as indicated by the screenshot.

Starfall '...' errored for player [redacted]
Player disconnected!

Server-side wouldn't have this happen unless the client actually left the game

@yingKatsu
Copy link
Contributor Author

yup clientside. i see my code erroring for people in this way when they experience lag spikes (someone loading a megapac) and their game freezes a sec, which is why im pretty sure its fullupdates again

@thegrb93
Copy link
Owner

thegrb93 commented Nov 4, 2024

See if #1893 fixes it

@thegrb93 thegrb93 closed this as completed Nov 4, 2024
@thegrb93 thegrb93 reopened this Nov 4, 2024
@Advers
Copy link
Contributor

Advers commented Nov 9, 2024

Still happens sometimes. Just happened to me a minute ago. Seemed to happen while the user was initializing or just after

@Advers
Copy link
Contributor

Advers commented Nov 9, 2024

nevermind, it just seems to be PVS or fullupdate dependent

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

We need player entities to be always_transmit I think. The fact they go invalid and don't exist for other clients is just crazy.

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

I think its something to do with source engine's anti-cheating

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

Actually, I have another idea that'll work

@wrefgtzweve
Copy link
Contributor

players can be invalid after a full update, They're resynced by default every 10s lots of servers up that though

it's not a anticheat thing but a garry hack to fix something
https://wiki.facepunch.com/gmod/Networking_Usage#svplayerforcedupdateissue

@yingKatsu
Copy link
Contributor Author

yingKatsu commented Nov 9, 2024

https://cdn.discordapp.com/attachments/921945120167833613/1304905421676478524/2024-11-09_14-24-29.mp4?ex=67311760&is=672fc5e0&hm=56a59544d94a55f28a1e14dd850018c855c8bac7c13fda521ebeebdba63af4ac&
latest version of gmod with only latest ver of starfall and dev library for sf

playerInstances table emptying itself for some reason.

my chips have been nonsensically "CPU Quota Reached!" erroring for a while now
noticed that their quota tooltips were freezing and not updating.
the reason why is because the quota is literally not being calculated bc the for loop that loops all instances is looping an empty table
the instances still run and delete as normal

code used:

local print = print
local printTable = printTable
dev.setGlobal()

print(SysTime())
for pl, insts in pairs(SF.playerInstances) do
    for instance in pairs(insts) do
        print(pl, instance.entity)
    end
end

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

@yingKatsu can you open a new issue and tell how to make that happen?

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

Nevermind, it was actually easy to reproduce

@thegrb93
Copy link
Owner

thegrb93 commented Nov 9, 2024

@yingKatsu fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants