-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String Constant Conflicts #60
Comments
Commit 4b1684b is not a fix, just a quick workaround for working with the Vice City SCM. |
Since #63, we should exclude the object models enum from the search. |
|
Remark: III Source Code have variables which collides with level models, and level models have priority over variables when used in a Plus, we perform this check here which I don't feel is right. |
After adding constant collision checks, the gta3 source code no longer compiles, which means they had no such check on the compiler of the first chapter: https://travis-ci.org/thelink2012/gta3sc/jobs/183137213 |
String constants may have collisions. For instance, the
CAMMODE
enumeration contains aSNIPER
constant, same name of aCARPEDMODEL
constant.The implication of this is that the following may generate different output depending on how we evaluate the search for a constant:
In fact, this ends up using
CARPEDMODEL
in miss2, while it uses theCAMMODE
enum here.Specify the evaluation order of enumerations!
The text was updated successfully, but these errors were encountered: