Verilator string parameters not generated correctly

[rishubn]

Verilator requires string parameters to be surrounded by quotes:
-Gparam="value"

Strings

Strings must be in double quotes (“”). They must be escaped properly on the command line, e.g. as -GSTR="\"My String\"" or -GSTR='"My String"'

If given a dict like { "param" : "value" } cocotb_test will generate -Gparam=value and Verilator will fail to compile.

Some simple logic can be added to do this wrapping in simulator.py:

for name, value in parameters.items():
            parameters_cmd.append("-G" + name + "=\"" + str(value) + "\"") if type(value) is str else parameters_cmd.append("-G" + name + "=" + str(value))

[themperek]

@rishubn Does #200 work for you?

[themperek]

Adding quotes fails on my local machine. Maybe I am doing something wrong.